AlexaLogC colorspace and framerate improvement by deactivating the oversampling code during the play

mikrosimage / duke

Duke is an opensource high resolution image and sequence viewer dedicated to visual effect and post production companies.

MIT License

109 stars 22 forks source link

AlexaLogC colorspace and framerate improvement by deactivating the oversampling code during the play #27

Closed cpichard closed 11 years ago

cpichard commented 11 years ago

I am not sure we should propagate the "is playing" information to the glsl code, even if it could be handy in some cases.

gchatelet commented 11 years ago

Thx for the pull request. Ideally I would like to pick only a subset of it as I don't like the isPlaying propagation as you mentionned. Do you mind submitting one pull request for the Alexa Colorspace and one for the correction of the sRGB colorspace ? We can manage to get the oversampling performance issue separately. Also I'll add a few bugs for those tasks.

gchatelet commented 11 years ago

I pushed two fixes for Alexa support and sRGB colorspace - basically copy/pasting your code, so I think we can drop this pull request. Merging those changes back to your branch should be easy. I'll work on #30 next.