mikrosk / z-tools

Zorro's Tools for Atari/GEM
0 stars 1 forks source link

Animaiton speed of zero causes no animation at all. #18

Open mikrosk opened 7 years ago

mikrosk commented 7 years ago

Some animated formats with speed values often contain 0. One can assume this means animate as fast as possible. However, when zview is paased 0 it does not animate at all, it just shows the first frame. It should default to some sane value and at least flip through the frames.

Reported by: lpgb

mikrosk commented 7 years ago

Hmm, I'd assume exactly this - no animation at all. However, if there are more frames after that, it doesn't make sense, true. I could do something as if speed == 0 then speed = 1 but I guess this can be done in the codec as well? Or the speed is part of an init phase?

Original comment by: mikrosk

mikrosk commented 7 years ago

Btw, please always attach a test file, I have very limited set of test data. :)

Original comment by: mikrosk

mikrosk commented 7 years ago

The formats that allow animaiton have values in the headers for that of course. However, sometimes they contain zero. I've read in some cases it's done on purpose to cause a race condition and make machines run hot, etc. All the web browers deal with it differently and have sane defaults. Typically if it's 0 I force 10, as anything less it often to fast. I deicded on 10 after doing some tests with the attached file and compariing it with firefox. Yes, the codec(s) can correct it, but then every codec has to correct it, dupicate code, etc. It would be easier if the viewer just handle it for all codecs that pass more than one frame.

Original comment by: lpgb

mikrosk commented 4 years ago

Fixed in 1.0.2, frame rate ist limited to 20 FPS, as all browsers do

Original comment by: thotto

mikrosk commented 2 weeks ago

jaysus