search

miktam / sizeof

Get size of a JavaScript object
MIT License
301 stars 45 forks source link

Recent deploy of 1.6.2 has breaking changes #62

Closed RcrsvRyan closed 2 years ago

RcrsvRyan commented 2 years ago

Hello,

I just wanted to let you know that the recent minor version update from 1.6.1 to 1.6.2 has some breaking changes in certain node versions.

Specifically, I think the version bump of the buffer package from V5 to V6 has the breaking changes. I am seeing this line tagged as an error in the buffer package:

(buffer's index.js, line 1216): this[++offset] * 2 ** 8 +

With the error:

SyntaxError: Unexpected token *

I believe it is the use of ** causing the above error. Would it be possible to revert the change and bump your Major version number up to 2 in order to undo the breaking change while still allowing your updates to be utilized by those who wish to do so?

miktam commented 2 years ago

@RcrsvRyan thank you!

Latest version should be fine, with the buffer version 5.7.x

RcrsvRyan commented 2 years ago

That looks good from my side. Thank you so much!