search

mila-iqia / atari-representation-learning

Code for "Unsupervised State Representation Learning in Atari"
https://arxiv.org/abs/1906.08226
MIT License
240 stars 50 forks source link

unused naff_fc_size parameter #63

Closed AnxietyYoungPoet closed 4 years ago

AnxietyYoungPoet commented 4 years ago

https://github.com/mila-iqia/atari-representation-learning/blob/aa37bf5858ca267ea0a0615e1a727308d5628e0d/atariari/methods/no_action_feedforward_predictor.py#L28-L30 In NaFFPredictor, the fc layer uses the feature_size from the encoder as the layer width, hence the naff_fc_size is left unused. Also, Sequential is used here, so it seems there might be multiple layers.

eracah commented 4 years ago

Oh good catch! I believe it was initially used, but then we realized to make the capacity the same as the VAE, the "middle" FC layer could only be a feature_size x feature_size matrix. We'll remove that argument

AnxietyYoungPoet commented 4 years ago

@eracah Got it! Thanks for your clarification!