search

mila-iqia / blocks-examples

Examples and scripts using Blocks
MIT License
147 stars 94 forks source link

Remove machine translation and add a link to an external repo #63

Open rizar opened 8 years ago

rizar commented 8 years ago

Let us start the procedure of moving the machine translation code out of Blocks-examples. @orhanf , would you like to create a new repository for it? Or maybe I should create a new repository under @mila-udem? What do you guys think, @bartvm and @dwf?

nouiz commented 8 years ago

What are the motivation to move this outside of blocks-examples?

On Mon, Nov 23, 2015 at 10:31 AM, Dzmitry Bahdanau <notifications@github.com

wrote:

Let us start the procedure of moving the machine translation code out of Blocks-examples. @orhanf https://github.com/orhanf , would you like to create a new repository for it? Or maybe I should create a new repository under @mila-udem https://github.com/mila-udem? What do you guys think,

@bartvm https://github.com/bartvm and @dwf https://github.com/dwf?

You can view, comment on, or merge this pull request online at:

https://github.com/mila-udem/blocks-examples/pull/63 Commit Summary

  • Remove machine translation and a link to an external repo

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks-examples/pull/63.

rizar commented 8 years ago

Because Blocks-examples and NMT demo have quite different purposes.

Blocks-examples is supposed to contain minimalistic toy examples of using Blocks. We would like to keep it small, especially in terms of the maximum size of an example. We are committed to keep all examples fully functional for the cutting-edge Blocks, which means that for every Blocks PR necessary changes have to be applied here.

NMT demo, on the other hand, is a fully-functional machine translation implementation. It's purpose is to reproduce results from a few machine translation papers. It has a lot of code dealing with real-world issues specific to machine translation and also attracts a broad audience that does not want to learn anything about Blocks or even Theano, but just wants to train a machine translation model.

Trying to sum it up, I don't think that Blocks-examples should contain real-world examples with all their overwhelming complexity, because this is too much of a load for Blocks maintainers.

orhanf commented 8 years ago

@rizar to double check, according to b29e1fc, i'm moving it under https://github.com/orhanf/neural-MT , is that good or will be moved to another repo?

rizar commented 8 years ago

This URL is just a placeholder to start the discussion. Maybe this should be @mila-udem repository, I don't know yet.

On 23 November 2015 at 11:32, Orhan Firat notifications@github.com wrote:

@rizar https://github.com/rizar to double check, according to b29e1fc https://github.com/mila-udem/blocks-examples/commit/b29e1fc2b38ac5e6900e6a47bc2e11ec5752e003, i'm moving it under https://github.com/orhanf/neural-MT , is that good or will be moved to another repo?

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks-examples/pull/63#issuecomment-158988503 .

dwf commented 8 years ago

Looks like we will need the fix from https://github.com/mila-udem/blocks/commit/e185f3d26c7432f9ab5cb59c3b7f037092a5b9d1 for the buildbot.