search

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework
MIT License
27 stars 40 forks source link

Plot not compatible with Bokeh 0.9.1 #15

Closed rizar closed 9 years ago

rizar commented 9 years ago

Sad but true, see also the discussion in #11. @mdda , if you feel you can tackle this, that would be great, since I am by no means a Bokeh guru.

mdda commented 9 years ago

Ok - I'm game for having a look at this. My original problem with fixing #11 is that it seems to work (for me) against v0.9.0 from PyPI (and the bokeh changelog doesn't include any obvious smoking gun). Let me play around with Plot against bokeh:master over the weekend and see where I get...

For now, my acceptance test will be whether the sample iPython notebook ( https://github.com/mdda/pycon.sg-2015_deep-learning/blob/master/ipynb/1-LivePlotting.ipynb ) works.

rizar commented 9 years ago

Bokeh 0.9.0 works for me as well. But now 0.9.1 is also on PyPI. And indeed the changelog does not give a cue.

rodrigob commented 9 years ago

This seems broken (bokeh 0.9.3), any chance of having it fixed ?

dwf commented 9 years ago

This is a bug in Bokeh, see bokeh/bokeh#2787. Apparently the index page for the Bokeh server was kind of an afterthought, and nobody noticed when it broke following a change to the jQuery settings about 5 months ago ( bokeh/bokeh@607c920 ). I don't really know JS that well or CoffeeScript at all, but if you do, feel free to give it a shot. (I just bisected it yesterday, so there's a chance one of the Continuum guys will have some insight how to fix it in the coming week.)

dwf commented 9 years ago

I've managed to fix it, pending the pull request's acceptance. See bokeh/bokeh#2792.

rizar commented 9 years ago

That sounds great!

On 1 September 2015 at 00:48, David Warde-Farley notifications@github.com wrote:

I've managed to fix it, pending the pull request's acceptance. See bokeh/bokeh#2792 https://github.com/bokeh/bokeh/pull/2792.

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks-extras/issues/15#issuecomment-136585246 .

dwf commented 9 years ago

Good news everyone!

The relevant PR has been merged. There should be a development build of Bokeh out by the end of the week, or latest, early next week. In the mean time, you can take advantage of it by building from master (although building Bokeh is somewhat involved, it is relatively painless with Conda in your arsenal).

dwf commented 9 years ago

You can use the release here, or install with conda: 

conda install bokeh==0.10.0dev.78671086 -c bokeh/channel/dev

which contains the fix.