search

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework
MIT License
27 stars 40 forks source link

Add PRelu Brick #18

Closed janchorowski closed 6 years ago

janchorowski commented 9 years ago

Please merge after Blocks mila-udem/blocks#785

dwf commented 9 years ago

@rizar Why do you feel this belongs in blocks-extras and not blocks? These sorts of units have appeared several times in the literature by now.

rizar commented 9 years ago

@dwf, I haven't done serious research to have a strong opinion, but since you yourself say "these sorts of units" using plural, it kind of makes a point. We can't host all varieties of such units, I would rather wait until there is particular unit like that which was used in let's say 20 papers before it makes it to the core and becomes our responsibility.

This was a very vague argumentation though. Until we come up with written guidelines describing difference between Blocks and Blocks-extras all such decision will be subjective and involve a bit of randomness. On the bright side, they are easy to revert.

P. S. Maybe another way to look at the issue: it should be easier for us to merge immediately to Blocks-extras and wait for criticism from knowledgeable people. If everybody is more or less with a component, it can move to the main repo.