search

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework
MIT License
27 stars 40 forks source link

Add FixedPermutation and PermutationMatrix. #2

Closed dwf closed 9 years ago

rizar commented 9 years ago

I am confused, did we decide to test blocks-extras or not?

rizar commented 9 years ago

Since this is blocks-extras I did not try too hard to read it, but it looks all right. I would not put in __init__.py though, imagine how huge it will grow when people start actually contributing here. Maybe bricks/permutation.py?

bartvm commented 9 years ago

Yes, blocks-extras is tested (tests are also run as part of the Travis run for the core)

rizar commented 9 years ago

Unfortunately https://travis-ci.org/mila-udem/blocks-extras/builds/64037116 gives Could not find .travis.yml, using standard configuration. And there is no travis.yml in master in fact.

bartvm commented 9 years ago

Probably forgot to commit that then, I'll do it when I'm back in Montreal tonight On May 27, 2015 1:21 PM, "Dmitry Bogdanov" notifications@github.com wrote:

Unfortunately https://travis-ci.org/mila-udem/blocks-extras/builds/64037116 gives Could not find .travis.yml, using standard configuration. And there is no travis.yml in master in fact.

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks-extras/pull/2#issuecomment-106002922 .

rizar commented 9 years ago

Sure, no rush :)

dwf commented 9 years ago

Guess I'll have to rebase this after #3. Please remind me if I don't.

bartvm commented 9 years ago

Rebase away!

dwf commented 9 years ago

@bartvm Rebased.