search

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework
MIT License
27 stars 40 forks source link

Try to fix tests by not installing Bokeh dependencies #27

Closed rizar closed 8 years ago

rizar commented 8 years ago

Trying to fix #25

bartvm commented 8 years ago

Why not just add bokeh to req-travis-conda.txt with a pinned version?

bartvm commented 8 years ago

(And then just merge the two requirements file with cat, to clarify)

rizar commented 8 years ago

Because we still install all dependencies from requirements.txt from Blocks after that, see this line. I guess we should somehow installed a pinned version of Bokeh and insist that no packages are updated, but somehow --no-update-dependencies does not work for me in #27

bartvm commented 8 years ago

Well, strictly we don't even need to install that requirements.txt (everything should be installed already with req-travis-conda.txt). That said, I don't understand the problem? If you create a file req-travis-conda.txt with the contents bokeh==0.10 and then do this in .travis.yml:

- curl https://raw.githubusercontent.com/mila-udem/blocks/master/req-travis-conda.txt >> req-travis-conda.txt
- conda install -q --yes python=$TRAVIS_PYTHON_VERSION --file req-travis-conda.txt

The added bonus is that you can be sure that dependencies aren't duplicated between blocks-extras and Blocks.

bartvm commented 8 years ago

Looks like you did exactly that the same time I pressed the comment button :p I would use a separate file because it's consistent with the other repos (and scales more easily to possible future dependencies), but otherwise I think this solution should work.

rizar commented 8 years ago

I agree that a separate file makes sense. But I fail to understand why we install Blocks with requirements.txt on Travis, even though we have a special file req-travis-pip.txt for that.

bartvm commented 8 years ago

I guess the idea is that -r requirements.txt should not do anything. If it does it means that we are either missing dependencies in req-travis-*.txt, or the dependencies have gotten out of sync. If there are syntax errors in requirements.txt those would show up as well.

rizar commented 8 years ago

In this case we should install them without -q, so that we at least saw that something is done by visual inspection of the log.

Feel free to merge this PR.

bartvm commented 8 years ago

Agreed, the installation of blocks itself should really be done without -q.