Plot refactor - Githubissues

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework

MIT License

27 stars 40 forks source link

Plot refactor #34

Closed dwf closed 8 years ago

dwf commented 8 years ago

To be merged after rebasing on top of master after #32 is merged.

Break out a base class for other Bokeh-interacting Extensions.
Manipulate Session and Document objects instead of relying on stateful bokeh.plotting interface.
Get rid of open_browser as the signature had changed and so it that wasn't working anyway.

dwf commented 8 years ago

If anyone can give this a look, it'd be helpful.

rizar commented 8 years ago

David, we are awfully sorry, both Dima S and I are rushing for ICLR deadline... Please give us time until Monday to sort this shit out, and I promise, this PR will be on my very high priority list after that.

dwf commented 8 years ago

I figured as much, no problem.

dwf commented 8 years ago

@rizar Any objection to merging this? It still only works with Bokeh 0.9 but it contains a number of fixes that I've been using for a while and in particularly fixes unpickling and resumption of jobs with a Plot extension.

rizar commented 8 years ago

Do you mean 0.10? I thought 0.9 was a particularly bad version for us...

dwf commented 8 years ago

Yes sorry 0.10.

rizar commented 8 years ago

Honestly, I do not know Bokeh well enough to confidently review the last commit. Just go ahead and merge :)

dwf commented 8 years ago

@ddtm I think you might benefit from this. You said you were having job resumption issues of some sort.

dwf commented 8 years ago

(Specifically a JSON decode error upon resuming)