First refactoring of new SequenceGenerator

mila-iqia / blocks-extras

A collection of extensions to the Blocks framework

MIT License

27 stars 40 forks source link

Closed rizar closed 8 years ago

rizar commented 8 years ago

A few changes:

let Readout use contexts for computation of the cost - can be necessary for some advanced methods, such as e.g. REINFORCE with baseline
simplify Readout and Feedback interfaces by using simple property names such as input_dims and output_dims
separates AbstractReadout and MergeReadout. Let interface be separated from the implementation!

@pbrakel, you can have a say!

pbrakel commented 8 years ago

I think the new property names are a large improvement. I have nothing against the other changes either.

rizar commented 8 years ago

Seems to work.