mila-iqia / blocks-extras

A collection of extensions to the Blocks framework
MIT License
27 stars 40 forks source link

PlotingExtension.sub inconsistency #52

Open rustonaut opened 7 years ago

rustonaut commented 7 years ago

When skimming the code I noticed that there is a Bug wrt. the self.sub field

It is assigned in the constructor with:

self.sub = self._start_server_process() if self.start_server else None

but _start_server_process does not return anything but set's self.sub = ... which is then overwritten with its non existing return value (aka. None)

Also self.sub isn't used anywhere

Open questions?

Note this is a pretty minor bug, and this is a class which probably gets completely rewritten anyway

rustonaut commented 7 years ago

no explicit self.sub assignment is done in the __setstate__ method.

dmitriy-serdyuk commented 7 years ago

This should be fixed with #35.