Open rustonaut opened 7 years ago
When skimming the code I noticed that there is a Bug wrt. the self.sub field
self.sub
It is assigned in the constructor with:
self.sub = self._start_server_process() if self.start_server else None
but _start_server_process does not return anything but set's self.sub = ... which is then overwritten with its non existing return value (aka. None)
_start_server_process
self.sub = ...
None
Also self.sub isn't used anywhere
Open questions?
self._sub
Note this is a pretty minor bug, and this is a class which probably gets completely rewritten anyway
no explicit self.sub assignment is done in the __setstate__ method.
__setstate__
This should be fixed with #35.
When skimming the code I noticed that there is a Bug wrt. the
self.sub
fieldIt is assigned in the constructor with:
but
_start_server_process
does not return anything but set'sself.sub = ...
which is then overwritten with its non existing return value (aka.None
)Also
self.sub
isn't used anywhereOpen questions?
self._sub
attribute if it has a sub?Note this is a pretty minor bug, and this is a class which probably gets completely rewritten anyway