Fix for Pool.out_shape breaking change in Theano.

mila-iqia / blocks

A Theano framework for building and training neural networks

Other

1.16k stars 351 forks source link

Fix for Pool.out_shape breaking change in Theano. #1154

Closed dwf closed 8 years ago

dwf commented 8 years ago

This is causing our tests to fail and is caused by a boneheaded new assumption in Theano/Theano@a16e91f7933e20b1ae77c1d43f8278af9333f2ab that breaks old behaviour that we relied upon (see Theano/Theano#5088).

I don't really want to wait around for Theano to get its shit together, so this introduces a version that works before and after the offending Theano commit. It's already caught by our tests, obviously, so no need for a regression test.

nouiz commented 8 years ago

I did a PR on Theano with a fix: https://github.com/Theano/Theano/pull/5090

All Theano pool cpu tests pass.

nouiz commented 8 years ago

The CPU and GPU tests for pool passed locally on my PR to Theano. So it could be merged rapidly.

nouiz commented 8 years ago

theano PR is merged.

dwf commented 8 years ago

Alright, I guess there's no need for this after all.