search

mila-iqia / blocks

A Theano framework for building and training neural networks
Other
1.16k stars 351 forks source link

AggregationSchemes for Maximum and Minimum. #1162

Closed dwf closed 8 years ago

dwf commented 8 years ago

Surprised to find these didn't already exist. Fixes #129.

dmitriy-serdyuk commented 8 years ago

It is issue #129 .

dwf commented 8 years ago

So it is.

dwf commented 8 years ago

I added a Concatenate scheme for completeness.

dmitriy-serdyuk commented 8 years ago

Sorry, forgot about this PR. It looks good. I have one question: do you think that concatenate aggregator should always create an extra dim? For example, in your test [4, 12, 7, 5] should be [[4, 12], [7, 5]].

dwf commented 8 years ago

That would make things simpler wouldn't it? Changed in 7e8a556.

dmitriy-serdyuk commented 8 years ago

Cool, LGTM.