search

mila-iqia / blocks

A Theano framework for building and training neural networks
Other
1.16k stars 351 forks source link

Remove --allow-external #1198

Closed dmitriy-serdyuk closed 6 years ago

dmitriy-serdyuk commented 6 years ago

For mila-udem/fuel#405

@nouiz

nouiz commented 6 years ago

CI fail.

nouiz commented 6 years ago

It could need the same fix as I did in Fuel (define an env variable MKL_THREADING_LAYER=GNU)

dmitriy-serdyuk commented 6 years ago

Fixed

nouiz commented 6 years ago

2 CI still fail. I think a new version of pep8 is used. That caused a failure in Fuel

dmitriy-serdyuk commented 6 years ago

Ok, I figured out the problem. Virtualenv puts a bunch of its things into bin directory. Scrutinizer crashes on those files.

dmitriy-serdyuk commented 6 years ago

@nouiz I give up. I was tinkering for quite a while. I fixed Travis and Scrutinizer tests. But I have no idea what happens to Scrutinizer analysis.

nouiz commented 6 years ago

So, what do we do? As the tests passed, we could merge. This would fix possible security issue, so I would go in that direction.

dmitriy-serdyuk commented 6 years ago

OK, let me cleanup history then

On Thu, Sep 6, 2018, 02:10 Frédéric Bastien notifications@github.com wrote:

So, what do we do? As the tests passed, we could merge. This would fix possible security issue, so I would go in that direction.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mila-udem/blocks/pull/1198#issuecomment-418873808, or mute the thread https://github.com/notifications/unsubscribe-auth/ACvVJ4aSpIr3aPKrDoVCYyhSFRVs042qks5uYDaxgaJpZM4WSLx3 .