search

mila-iqia / blocks

A Theano framework for building and training neural networks
Other
1.16k stars 351 forks source link

blocks.serialization.load ignores recursionlimit from .blocksrc #743

Open rizar opened 9 years ago

rizar commented 9 years ago

Subject says it all. I increased recursionlimit and thought it would make loading more robust, but no...

Also it should be possible to configure what is used for loading, pickle or cPickle. For this a PR to Theano should be done.

Finally I think that secure_dump should also use the recursionlimit setting.

This might be related to #737

rizar commented 9 years ago

A closer look revealed that recursion limit is changed in the main loop. However, if one tries to use load outside of main_loop.run() they will find out that recursion_limit doesn't work...

dwf commented 9 years ago

cPickle isn't available in Python 3 (in fact I think "pickle" provides the old cPickle implementation in this case).

rizar commented 9 years ago

Sure, but we typically use six.moves.cPickle and it works just fine.

dwf commented 9 years ago

My point is that this setting will have no effect on Python 3, as pickle and cPickle in six.moves are the same.

On Sun, Jul 5, 2015 at 9:51 AM, Dmitry Bogdanov notifications@github.com wrote:

Sure, but we typically use six.moves.cPickle and it works just fine.

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks/issues/743#issuecomment-118623293.