Closed mirkobronzi closed 3 years ago
Still to do:
Mirko and I discussed the PR and the remaining changes earlier today, and came up with a list of TODOs for PyTorch-Lightning:
self.save_hyperparameters(...)
; this might log stuff for MLFlow or other outputs that could be missing otherwise.train.py
module; the Trainer object constructor can receive a ton of flags that can change the training behavior of the model, but that should probably not be hard-coded once the cookiecutter project is generated. Reading and forwarding relevant arguments from a subsection of the hyperparameter config file would be ideal.I've got a side-project in the works that might go through some of these issues in the future, so we'll update the branch if possible!
Hi @plstcharles - I fixed most of the issues above and opened the PR for review. Let me know what you think..
I recently opened a PR for this branch (#22) that should fix the remaining issues and make this a gogogo-green!
Add support for pytorch lightning and keras. (so, in short, replacing the train loop with these more high-level API)
Also, it switched from travis to github actions.