mila-iqia / cookiecutter-pyml

MIT License
19 stars 8 forks source link

Add images to tensorboard #87

Open jerpint opened 1 year ago

jerpint commented 1 year ago

Adds support to plot images of the first batch of the validation set to tensorboard

image

mirkobronzimila commented 1 year ago

@jerpint : still have to check this PR (and some of the others), but I was wondering if we are getting too specific on the current toy task (like, here we assume we will work with images). In the end, the toy task will be erased in the first week or work (or something like that), to make space for the real task. But again, not sure if this PR is also doing more stuff.. I will be back later on this PR.

jerpint commented 1 year ago

This PR uses a callback to show how to log an image to tensorboard, so it can easily be removed by simply removing the callback, and consulted to find out how to do it, but good point, we don't want to overdo it either. Not sure what the best tradeoff would be

mirkobronzi commented 1 year ago

This PR uses a callback to show how to log an image to tensorboard, so it can easily be removed by simply removing the callback, and consulted to find out how to do it, but good point, we don't want to overdo it either. Not sure what the best tradeoff would be

this is a perfect example for code logic that should be in the new repository that we will create. So it does not weight on the cookiecutter, but it's still available. Do you see any disadvantages with that?

jerpint commented 1 year ago

Once we have cookiecutter in a stable state, i will probably maintain a separate repo with a bunch of killer features