search

mila-iqia / fuel

A data pipeline framework for machine learning
MIT License
867 stars 268 forks source link

Bug in Scrutinizer causes files containing ellipsis to be skipped #159

Open bartvm opened 9 years ago

bartvm commented 9 years ago

Just sent them an e-mail about it:

I recently ran into what seems to be a bug in Scrutinizer's static code analysis. Consider any recent analysis log of the Fuel project, of which I'm a developer:

- fuel/converters/svhn.py: Could not resolve type id '_ast.Ellipsis' into a subtype of [simple type, class com.scrutinizerci.worker.parser.python.PythonNode]
 at [Source: java.io.StringReader@69b3fb71; line: 1, column: 53327]
- fuel/datasets/hdf5.py: Could not resolve type id '_ast.Ellipsis' into a subtype of [simple type, class com.scrutinizerci.worker.parser.python.PythonNode]
 at [Source: java.io.StringReader@176a14d9; line: 1, column: 187643]
- fuel/converters/base.py: Could not resolve type id '_ast.Ellipsis' into a subtype of [simple type, class com.scrutinizerci.worker.parser.python.PythonNode]
 at [Source: java.io.StringReader@53320946; line: 1, column: 36921]

It seems that these are the files that contain Python's ellipsis object, i.e. they index an array using something like x[..., 0]. These files are completely ignored by the analysis right now.

vdumoulin commented 9 years ago

@bartvm what's the status on this?