search

mila-iqia / fuel

A data pipeline framework for machine learning
MIT License
868 stars 268 forks source link

Bump Pillow to be sure it is a secure version #405

Closed nouiz closed 6 years ago

dmitriy-serdyuk commented 6 years ago

Some tests fail with the new pillow FAIL: tests.transformers.test_image.TestRandom2DRotation.test_random_2D_rotation_batch_stream. I think their defaults changed.

dmitriy-serdyuk commented 6 years ago

It looks like the old pillow had a bug there. I tested on images of bigger sizes and pillow 3.4 -- 5.2 works fine and the same here.

Not sure why old pillow had this answer, but in this test the rotation angle is 12.25 degrees. It means that the difference in the output image will be less than 1 pixel. So, the new pillow is giving the right answer.

dmitriy-serdyuk commented 6 years ago

Basically, it fails now only because of --allow-external in blocks. I removed it in mila-udem/blocks#1198.

Feel free to merge both PRs.

dmitriy-serdyuk commented 6 years ago

Tests passed, I merge