search

mila-iqia / milabench

Repository of machine learning benchmarks
https://milabench.readthedocs.io
MIT License
33 stars 26 forks source link

soft_actor_critic crash because of API change #28

Closed Delaunay closed 2 years ago

Delaunay commented 2 years ago

Gym removed a method used by torchbench

https://github.com/pytorch/benchmark/blob/main/torchbenchmark/models/soft_actor_critic/envs.py#L237

https://github.com/openai/gym/commit/3a8daafce113c6161190c0252c6a3a340cc38fd4#diff-8f3ae46be618d936b191b5f32bad0dcc4674ea5385bafb31a6c02840a43fe76aL196

need to replace env.seed(...) by env.reset(seed=seed)

Delaunay commented 2 years ago

#1271

Delaunay commented 2 years ago

Fixed in the main repo, but we cannot use newest version yet because of #29