use https instead of git uris

tbugfinder commented 3 years ago

Hi,

builds running in firewalled networks might fail. Would it be possible to convert to https URIs?

Thanks.

lcebaman commented 1 year ago

Is there any progress on this?

Delaunay commented 1 year ago

Will the pre-built docker images solve this issue ? They contain all the data for the bench to run right away, no additional downloads are necessary.

Delaunay commented 1 year ago

Can you provide us with the URIs you found to be problematic ?

tbugfinder commented 1 year ago

IIRC, it was about those required by poetry when building the docker image:

$ git log -1
commit 5349c6b8b58261149799d52b742720ad6224208c (HEAD -> master, tag: mila-ao-2020-2, origin/master, origin/dev, origin/HEAD)
Author: Olivier Breuleux <breuleux@gmail.com>
Date:   Thu Aug 6 10:21:27 2020 -0400

    Require -o or $MILARUN_OUTROOT

----------------------------

$ git grep git:
poetry.lock:url = "git://github.com/breuleux/pytorch-a2c-ppo-acktr-gail"
poetry.lock:url = "git://github.com/breuleux/apex"
poetry.lock:url = "git://github.com/breuleux/babyai"
poetry.lock:url = "git://github.com/breuleux/baselines"
pyproject.toml:a2c-ppo-acktr = {git = "git://github.com/breuleux/pytorch-a2c-ppo-acktr-gail", branch = "milatweak"}
pyproject.toml:apex = {git = "git://github.com/breuleux/apex", branch = "milatweak"}
pyproject.toml:babyai = {git = "git://github.com/breuleux/babyai", branch = "master"}
pyproject.toml:baselines = {git = "git://github.com/breuleux/baselines", branch = "milatweak"}

I was using the tag mile-ao-2020-2.

https://github.com/mila-iqia/milabench/blob/mila-ao-2020-2/pyproject.toml#L14

tbugfinder commented 1 year ago

I'll give the container a try, too :-D thx!

Delaunay commented 1 year ago

Ok, all those links are gone now. I am going to mark it as resolved then.

mila-iqia / milabench

use https instead of git uris #4