codecov-commenter
commented
8 months ago Codecov Report
Attention: 27 lines in your changes are missing coverage. Please review.
Comparison is base (
b823319) 61.03% compared to head (e4686bb) 61.73%.
| Files | Patch % | Lines |
|---|---|---|
| milatools/cli/commands.py | 51.16% | 21 Missing :warning: |
| milatools/cli/remote.py | 77.77% | 4 Missing :warning: |
| milatools/cli/local.py | 80.00% | 1 Missing :warning: |
| milatools/cli/utils.py | 75.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #101 +/- ## ========================================== + Coverage 61.03% 61.73% +0.69% ========================================== Files 9 9 Lines 1404 1445 +41 ========================================== + Hits 857 892 +35 - Misses 547 553 +6 ``` | [Flag](https://app.codecov.io/gh/mila-iqia/milatools/pull/101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/mila-iqia/milatools/pull/101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `24.91% <14.28%> (+13.73%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/mila-iqia/milatools/pull/101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `61.73% <61.42%> (+0.69%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cd $SCRATCHbeforesallocandsbatchon the mila clusterbanner_timeout: 60in theconnect_kwargsthat are passed from fabric toparamiko.SSHClient.connectfor the mila cluster when we create amilatools.cli.remote.Remoteobject. This is the most "experimental" change that might require some more testing. In my experience it consistently solved a new paramiko "Unable to parse SSH banner" error that I started experiencing during tests.