Closed lebrice closed 5 months ago
Attention: Patch coverage is 57.87140%
with 190 lines
in your changes are missing coverage. Please review.
Project coverage is 59.20%. Comparing base (
7c733d1
) to head (2daba0b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For what it's worth, I'm not familiar with the code and I read the PR in diagonal to get a sense of what was in there. It looked alright in general. The main question that I would have is whether all the work for nice progress bars and whatnot will be obsolete when MFA kicks in? Can users log in manually once, perform the 2FA ritual, and then run this command without having to do it again?
For what it's worth, I'm not familiar with the code and I read the PR in diagonal to get a sense of what was in there. It looked alright in general. The main question that I would have is whether all the work for nice progress bars and whatnot will be obsolete when MFA kicks in? Can users log in manually once, perform the 2FA ritual, and then run this command without having to do it again?
Yes! The goal of this RemoteV2
is to use the ControlMaster directive of OpenSSH, so that the connection (and 2fa) is only performed once and a socket file is created. The connection is then reused.
@gyom Here's the flow with 2FA: Notice how after the first interrupted run, there is no need to perform 2FA again:
https://github.com/mila-iqia/milatools/assets/13387299/662b6639-0b72-4de2-aeb3-6cf036dacd35
preview:
https://github.com/mila-iqia/milatools/assets/13387299/1f56da91-faa8-42b1-a4c6-53553d68171d