search

mila-iqia / milatools

Tools to connect to and interact with the Mila cluster
MIT License
63 stars 12 forks source link

Bugfix for mila code in WSL #131

Closed lebrice closed 2 weeks ago

lebrice commented 3 weeks ago

When a user launches mila code from WSL, it should end up running powershell.exe code (...), otherwise the vscode window opens a local file (that doesn't exist) instead of opening on the remote.

This fixes a bug whereby the running_inside_WSL function wasn't being called anymore in mila code.

Signed-off-by: Fabrice Normandin normandf@mila.quebec

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.16%. Comparing base (9b4a7cd) to head (029e9b2). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ========================================== + Coverage 72.93% 74.16% +1.23% ========================================== Files 15 17 +2 Lines 2176 2311 +135 ========================================== + Hits 1587 1714 +127 - Misses 589 597 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.