Fix running tests that use SSH in CI

mila-iqia / milatools

Tools to connect to and interact with the Mila cluster

MIT License

60 stars 11 forks source link

Fix running tests that use SSH in CI #77

Closed lebrice closed 9 months ago

lebrice commented 9 months ago

add a build step in the GitHub actions CI to setup passwordless ssh to localhost for the rest of the tests.
- This makes it possible to run a lot of the tests inside test_remote.py for the Remote class as part of the CI.
Only run tests that require the -s flag to run when running tests with the -s flag.
- This alleviates the "Operation on closed file" issue that happens for example here: https://github.com/mila-iqia/milatools/actions/runs/7009695285/job/19068696634?pr=77

lebrice commented 9 months ago

Currently waiting on the second commit to be processed. There seems to be some downtime of the GitHub runners https://www.githubstatus.com/

Update - Customers are seeing delays in pushed commits appearing on pull requests. We are currently investigating. Nov 27, 2023 - 19:46 UTC Investigating - We are investigating reports of degraded performance for Pull Requests Nov 27, 2023 - 19:43 UTC