codecov-commenter
commented
8 months ago Codecov Report
Attention: 47 lines in your changes are missing coverage. Please review.
Comparison is base (
9c4f213) 55.74% compared to head (e3d4249) 59.05%. Report is 1 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| milatools/cli/init_command.py | 71.53% | 39 Missing :warning: |
| milatools/cli/local.py | 82.60% | 4 Missing :warning: |
| milatools/cli/commands.py | 25.00% | 3 Missing :warning: |
| milatools/cli/remote.py | 92.30% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #84 +/- ## ========================================== + Coverage 55.74% 59.05% +3.31% ========================================== Files 9 9 Lines 1202 1270 +68 ========================================== + Hits 670 750 +80 + Misses 532 520 -12 ``` | [Flag](https://app.codecov.io/gh/mila-iqia/milatools/pull/84/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/mila-iqia/milatools/pull/84/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `11.25% <0.00%> (?)` | | | [unittests](https://app.codecov.io/gh/mila-iqia/milatools/pull/84/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `59.05% <73.44%> (+3.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR does the following:
sallocandsbatchcommands on that SLURM cluster.SLURM_CLUSTERenvironment variable, and that hostname will be used for the tests.This PR opens the door to doing a lot more really nice integration tests!
Let me know what you think. :)