mila-iqia / milatools

Tools to connect to and interact with the Mila cluster
MIT License
60 stars 11 forks source link

Add support for DRAC clusters to the `mila code` command [MT-71] #85

Closed lebrice closed 7 months ago

lebrice commented 9 months ago

This PR:

TODOs:

codecov-commenter commented 8 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (aa953ab) 58.50% compared to head (5090f12) 60.48%.

Files Patch % Lines
milatools/cli/commands.py 9.09% 30 Missing :warning:
milatools/cli/utils.py 83.33% 4 Missing :warning:
milatools/cli/vscode_utils.py 94.44% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #85 +/- ## ========================================== + Coverage 58.50% 60.48% +1.97% ========================================== Files 9 9 Lines 1270 1364 +94 ========================================== + Hits 743 825 +82 - Misses 527 539 +12 ``` | [Flag](https://app.codecov.io/gh/mila-iqia/milatools/pull/85/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/mila-iqia/milatools/pull/85/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `11.36% <11.96%> (?)` | | | [unittests](https://app.codecov.io/gh/mila-iqia/milatools/pull/85/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `60.48% <68.37%> (+1.97%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.