mila-iqia / milatools

Tools to connect to and interact with the Mila cluster
MIT License
60 stars 11 forks source link

Fix dynamic versioning not working in the CI #89

Closed lebrice closed 7 months ago

lebrice commented 7 months ago

During the recent release, the package version was 0.0.0 in the GitHub CI: https://github.com/mila-iqia/milatools/actions/runs/7572023233/job/20621010227#step:6:36

This is the same issue as in https://github.com/mtkennerly/poetry-dynamic-versioning/issues/145

I made the release myself with poetry publish --build on my local machine, although in retrospect I probably shouldn't have done that.

This PR is an attempt to fix the issue with the dynamic versioning in the GitHub CI so that the publishing it actually taken care of by GitHub Actions for the next release. I'm trying to do this by adapting the solution proposed in https://github.com/mtkennerly/poetry-dynamic-versioning/issues/145#issuecomment-1719645691 by installing the dynamic versioning plugin explicitly in the CI.

I find it surprising that doing poetry install wouldn't also install the poetry plugins though :thinking: