search

mila-iqia / milatools

Tools to connect to and interact with the Mila cluster
MIT License
62 stars 12 forks source link

Fix poetry lockfile issues (and add pre-commit hook) #90

Closed lebrice closed 8 months ago

lebrice commented 9 months ago

There can sometimes be errors with the poetry lockfile become out-of-sync with the pyproject.toml.

This PR adds a pre-commit hook to detect and prevent such errors.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6363e05) 52.49% compared to head (2f654b2) 60.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ========================================== + Coverage 52.49% 60.48% +7.99% ========================================== Files 9 9 Lines 1364 1364 ========================================== + Hits 716 825 +109 + Misses 648 539 -109 ``` | [Flag](https://app.codecov.io/gh/mila-iqia/milatools/pull/90/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/mila-iqia/milatools/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `?` | | | [unittests](https://app.codecov.io/gh/mila-iqia/milatools/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `60.48% <ø> (+9.82%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.