mila-iqia / milatools

Tools to connect to and interact with the Mila cluster
MIT License
62 stars 12 forks source link

Fix sshkeys passphrase issue with `mila init` [MT-72] #93

Closed lebrice closed 8 months ago

lebrice commented 9 months ago

Seems like the issue is caused by passing the passphrase using f"-N '{passphrase}'", as in ssh-keygen -t rsa -f {file_path} -N '{passphrase}'. I believe setting f"-N='{passphrase}'" might fix it.

Old command: ssh-keygen -t rsa -f {file_path} -N '{passphrase}' New command: ssh-keygen -t rsa -f {file_path} -N='{passphrase}'

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.03%. Comparing base (f8bb9c1) to head (f938f9c). Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
milatools/cli/init_command.py 70.37% 8 Missing :warning:
milatools/cli/local.py 80.00% 1 Missing :warning:
milatools/cli/remote.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ========================================== + Coverage 60.91% 61.03% +0.12% ========================================== Files 9 9 Lines 1379 1404 +25 ========================================== + Hits 840 857 +17 - Misses 539 547 +8 ``` | [Flag](https://app.codecov.io/gh/mila-iqia/milatools/pull/93/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/mila-iqia/milatools/pull/93/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `11.18% <5.71%> (-0.21%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/mila-iqia/milatools/pull/93/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia) | `61.03% <71.42%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mila-iqia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.