Closed lebrice closed 8 months ago
Attention: Patch coverage is 71.42857%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 61.03%. Comparing base (
f8bb9c1
) to head (f938f9c
). Report is 18 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
milatools/cli/init_command.py | 70.37% | 8 Missing :warning: |
milatools/cli/local.py | 80.00% | 1 Missing :warning: |
milatools/cli/remote.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
mila init
goes fine until it copies the SSH public key over to the authorized_keys file on the remote. This doesn't seem to work. There are extra ^M characters in theauthorized_keys
file on the cluster. Doingssh mila
asks for a passphrase (empty) and then asks for a password, then connects successfully.Seems like the issue is caused by passing the passphrase using
f"-N '{passphrase}'"
, as inssh-keygen -t rsa -f {file_path} -N '{passphrase}'
. I believe settingf"-N='{passphrase}'"
might fix it.Old command:
ssh-keygen -t rsa -f {file_path} -N '{passphrase}'
New command:ssh-keygen -t rsa -f {file_path} -N='{passphrase}'