search

mila-iqia / myia

Myia prototyping
MIT License
455 stars 46 forks source link

Add relay implementation to fully support conv2d_transpose in relay backend #346

Closed notoraptor closed 4 years ago

notoraptor commented 4 years ago

This PR extracts code from #338 and adds supplementary code to fix conv2d_transpose in relay backend. It is currently implemented as a full relay graph and seems to correctly support all values for groups, dilations, and other parameters.

This PR needs relay operation dilate to be added in TVM backend. I made a PR for that: https://github.com/apache/incubator-tvm/pull/5331

This way to do was more easy than changing all conv2d_transpose implementations in TVM backend. If everything is confirmed and all tests pass, I may work on hardcoding the relay graph implementation directly into TVM backend.

@breuleux @abergeron @fosterrath-mila

notoraptor commented 4 years ago

All tests succeed!