Modified for running with docker

mila-iqia / training

8 stars 7 forks source link

Modified for running with docker #23

Open nileshnegi opened 4 years ago

nileshnegi commented 4 years ago

Added Dockerfile for basic setup with dependency installation
Modified README.md with steps to use this Dockerfile
Modified README.md for discrepancy in the mlbench-report command example
Modified install_conda.sh to automate creation of mlperf conda environment
Modified install_dependencies.sh for running inside the docker container
Modified cgroup_setup.sh for running inside the docker container

breuleux commented 4 years ago

Cool, thanks!

This being said I'm reorganizing a lot of things right now (using poetry instead of conda, consolidating download/run/report under a single milarun command, etc.)

I did use your changes to adapt a Dockerfile for the new system (currently at https://github.com/breuleux/milabench but it'll be moved into the mila-iqia organization this weekend), so thanks for that. In addition to that, I consolidated the commands to make cgroups work within Docker into a script that's run as the entry point to the container, and that seems to work, so this should make things a good deal easier.