miladr / jalali

This Package helps developers to easily work with Jalali (Shamsi or Iranian) dates in Laravel 4 applications, based on Jalali (Shamsi) DateTime class. This Package is based on a Laravel 3 bundle "sallar/laravel-jdate" by Sallar Kaboli.
MIT License
47 stars 123 forks source link

Laravel 5 #10

Open kamioon opened 9 years ago

kamioon commented 9 years ago

Hi, Any plan for L5 ?

miladr commented 9 years ago

I didn't test it for L5 yet but i think it will work.

kamioon commented 9 years ago

I tested, it works. But you should not add Service provider ("Miladr\Jalali\JalaliServiceProvider" ) in config/app.php it will works with only namespace and adding:

use Miladr\Jalali\jDate;

where that you want Jalali date.

if add "Miladr\Jalali\JalaliServiceProvider" to providers array we have error.

miladr commented 9 years ago

You have error because "provides" function in service provider. Please remove "provides" function from service provider and inform me if it's working.

sinaghazi commented 9 years ago

L5 packaging has changed. There are several posts online about bridging L4->L5 and some workarounds. https://medium.com/@morrislaptop/bridging-laravel-4-packages-to-laravel-5-2081f19643c6

This specific issue wasn't fixed by removing "provides". Instead I remarked JalaliServiceProvider.php line 21: // $this->package('miladr/jalali');

It seems working.. still needs to be tested and to find out if it misses functionality

ebrahimradi commented 9 years ago

@miladr What should I do? can you help me?

saeedsajadi commented 9 years ago

من هم توی لاراول 5 مشکل داشتم باهاش که کاری که sinaghjazi کردن رو هم منم انجام دادم و مشکل حل شد. اما اگر شما مشکل رو برطرف کنید و یه ریلیز بدید بهتره ممنون

p3ym4n commented 7 years ago

Take a look at this : https://packagist.org/packages/p3ym4n/jdate

miladr commented 7 years ago

Unfortunately, i don't have enough time to maintain this package. consider using : https://github.com/opilo/farsi It's fully tested.

miladr commented 7 years ago

@p3ym4n Great work. I think you need to add tests to your package.

p3ym4n commented 7 years ago

@miladr It have tests 👍