Open kamioon opened 9 years ago
I didn't test it for L5 yet but i think it will work.
I tested, it works. But you should not add Service provider ("Miladr\Jalali\JalaliServiceProvider" ) in config/app.php it will works with only namespace and adding:
use Miladr\Jalali\jDate;
where that you want Jalali date.
if add "Miladr\Jalali\JalaliServiceProvider" to providers array we have error.
You have error because "provides" function in service provider. Please remove "provides" function from service provider and inform me if it's working.
L5 packaging has changed. There are several posts online about bridging L4->L5 and some workarounds. https://medium.com/@morrislaptop/bridging-laravel-4-packages-to-laravel-5-2081f19643c6
This specific issue wasn't fixed by removing "provides". Instead I remarked JalaliServiceProvider.php line 21: // $this->package('miladr/jalali');
It seems working.. still needs to be tested and to find out if it misses functionality
@miladr What should I do? can you help me?
من هم توی لاراول 5 مشکل داشتم باهاش که کاری که sinaghjazi کردن رو هم منم انجام دادم و مشکل حل شد. اما اگر شما مشکل رو برطرف کنید و یه ریلیز بدید بهتره ممنون
Take a look at this : https://packagist.org/packages/p3ym4n/jdate
Unfortunately, i don't have enough time to maintain this package. consider using : https://github.com/opilo/farsi It's fully tested.
@p3ym4n Great work. I think you need to add tests to your package.
@miladr It have tests 👍
Hi, Any plan for L5 ?