This continues from #3. This is the relevant diff (commit e22096bcd900de214308e7e411114fc1cf064d7b). The "Files changed" tab will not be helpful as it contains changes for the previous PRs.
If you merge this PR, it will merge all the other PRs.
Summary
fixes usage of props.childComponent to be reactive in case it changes, or else childStyle will be stale.
fix errors from childComponent not being an Element by guarding against non-Elements
Validate
Temporarily modify demo/src/package.json to have "solidjs-resizable-splitter-component": "file:../../", for the solidjs-resizable-splitter-component dependency so that it will use the local version of the lib rather than the outdated one from GitHub.
Then run npm run demo at the root of the repo, and the demo will use the local version of the lib.
Then see that the demo works (it previously has errors when running with the local version).
This continues from #3. This is the relevant diff (commit e22096bcd900de214308e7e411114fc1cf064d7b). The "Files changed" tab will not be helpful as it contains changes for the previous PRs.
If you merge this PR, it will merge all the other PRs.
Summary
props.childComponentto be reactive in case it changes, or elsechildStylewill be stale.childComponentnot being anElementby guarding against non-ElementsValidate
Temporarily modify
demo/src/package.jsonto have"solidjs-resizable-splitter-component": "file:../../",for thesolidjs-resizable-splitter-componentdependency so that it will use the local version of the lib rather than the outdated one from GitHub.Then run
npm run demoat the root of the repo, and the demo will use the local version of the lib.Then see that the demo works (it previously has errors when running with the local version).