milanghe / STMOZOO

0 stars 0 forks source link

Feedback #3

Open JietseV opened 2 years ago

JietseV commented 2 years ago
  1. Try using the unix functionality from Pluto. It is a bit confusing you use the unix alpha (the symbol) in the formulas but not further on when assigning the parameter you use "alpha". Same thing for gamma.
  2. I get several errors that say variables are not defined. It starts with the end_location that is not defined, subsequent steps can not be executed and give errors. The complete function works fine, but when explaining via the separate code blocks you have to make sure all variables are defined. Same with the playable_actions, you are not defining it anywhere, there I get again an error. Same for current_state, start_location.
  3. It is good building up the function like you do, like this every step is clearly explained!
  4. The example shows nicely how the Q-learning is implemented!