milankinen / livereactload

Live code editing with Browserify and React
MIT License
865 stars 61 forks source link

Add livereloadable react-router example #119

Open milankinen opened 8 years ago

milankinen commented 8 years ago

Continuing from #43.

LiveReactLoads need an example for react-router (and perhaps also an example where both react-router and redux are being used). I'm gonna use @tukkajukka's excellent example project as a template (if it's ok?).

The example will be a part of the upcoming 2.3.0 release (please see #118).

jukkatupamaki commented 8 years ago

@milankinen Yes, that is totally ok!

neemzy commented 8 years ago

Hi,

Any news regarding this example? :)

Thanks!

jukkatupamaki commented 8 years ago

@neemzy I just updated my React template and it uses now Redux, React Router and Livereactload. You can find that here: https://github.com/lemanse/simple-react-app

neemzy commented 8 years ago

@tukkajukka Thanks a ton, but my project isn't using Redux, and I therefore can't use syncHistoryWithStore. I'd really love to see a working example without Redux!

jukkatupamaki commented 8 years ago

There's a version without Redux if you checkout an earlier commit: https://github.com/lemanse/simple-react-app/commit/108f298cdac25334dd5c4fb3c5031d593f1720f2

On 02 Sep 2016, at 17:47, Tom Panier notifications@github.com wrote:

@tukkajukka Thanks a ton, but my project isn't using Redux, and I therefore can't use syncHistoryWithStore. I'd really love to see a working example without Redux!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

neemzy commented 8 years ago

Oh, right. I'll give it a try soon then :) Cheers! Feel free to close the issue if you want to.

milankinen commented 8 years ago

I've had no time to work with this yet. Sorry about that. I'll try to finish this as soon as I manage to get some time for my personal projects.

neemzy commented 8 years ago

No worries! Thanks :)

neemzy commented 8 years ago

I don't think this is really required anymore as the lib works seamlessly with react-router :)

milankinen commented 8 years ago

Nice to hear that! I think it's still good to have an example though, thus not closing this issue yet. 😄