search

milankinen / livereactload

Live code editing with Browserify and React
MIT License
865 stars 61 forks source link

Reload Complete, but no changes in HTML #134

Closed srrvnn closed 7 years ago

srrvnn commented 7 years ago

Hello folks, I need some help to figure out why hot loading is not working in my case.

I have everything setup like in the README.md and am using this command:

watchify public/js/app.js -o public/js/bundle.js -dv -p livereactload & node server.js

When I edit and save a component file in my project:

in the terminal I see:

Notify clients about bundle change 4572912 bytes written to public/js/bundle.js (1.63 seconds)

in the browser console I see:

LiveReactload :: Bundle changed bundle.js:389 LiveReactload :: Applying changes... bundle.js:215 > Reload module :: /Users/srrvnn/Projects/rst/public/js/components/LinksList.react.js > Patch component :: _component bundle.js:389 LiveReactload :: Reload complete!

and yet the browser HTML does not change to show the hot load.

what am I missing?

milankinen commented 7 years ago

Hi @srrvnn and sorry for the delayed answer!

I don't see any reason why your example shouldn't work. I actually cloned the repo and tested it and it indeed doesn't reload. This is definitely a bug but the reason is still unclear to me... 😁

octalmage commented 7 years ago

I'm seeing the same thing, still looking into it but I wanted to chime in.

milankinen commented 7 years ago

@octalmage Do you have any simplified example project (open source) re-producing this issue?

EugeneZ commented 7 years ago

The repo seems to be gone. I wish it was still around. I wonder if it would work with the new beta. @milankinen Do you happen to still have the clone?

milankinen commented 7 years ago

Nope. Unfortunately 😕

milankinen commented 7 years ago

I'm closing this one. Feel free to comment if the issue still exists and I'll re-open this.