search

milankl / ShallowWaters.jl

A type-flexible shallow water model that can run with 16-bit arithmetic.
MIT License
115 stars 20 forks source link

Making everything use a single structure #174

Closed swilliamson7 closed 7 months ago

swilliamson7 commented 7 months ago

For some reason I wasn't able to remove the Manifest.toml in the other pull request, so I closed that one and have opened a new. Same thing as before, I modified functions to run on a single structure, removed the redundant functions, and now also removed the Manifest.toml. I believe everything should work as it did before.

I haven't yet included the checkpointed time integration because I want to see if I can get it to work on my own computer with the modified package before adding it completely (so I'll run using ShallowWaters and see if that's enough to then run the checkpointed problem, I think it should be). This will also let me try everything with the new version of Enzyme, which theoretically sped up compile times

swilliamson7 commented 7 months ago

Should I be opening these pull requests to my own branch or the main branch?

milankl commented 7 months ago

Should I be opening these pull requests to my own branch or the main branch?

directly to main is fine! but now it's pointing to sw/single-struct again 😉