milantenk / ngx-interactive-paycard

Interactive Angular payment card library.
Other
79 stars 14 forks source link

Add tests for bulk of InteractivePaycardComponent #15

Closed brendoncaulkins closed 3 years ago

brendoncaulkins commented 3 years ago

This will raise your global coverage to 80%+ for all four major categories, which does a good deal of progress towards resolving #4 .

UpdatedCoverage

Adding tests for the CardComponent is still up for grabs.

Once this is through, I would suggest adding a coverage enforcement mechanism, like https://www.npmjs.com/package/karma-threshold-reporter to keep your coverage in check against future code changes..

Happy Hacktoberfest !!

milantenk commented 3 years ago

Thank you for the suggestion regarding the code coverage threshold value! 😄 I created an issue for that, I'll do it as I'll have some time for it.