search

milantenk / ngx-interactive-paycard

Interactive Angular payment card library.
Other
79 stars 14 forks source link

Use translated label strings from an optional parameter #3

Closed milantenk closed 4 years ago

milantenk commented 4 years ago

Currently the library has hard coded label string in English language. This is problematic, if someone would use the library in an other language context.

The requirement is to get these label strings as optional parameter in the library. The library should contain the original strings as default value, and if there are optional translated parameters, the form should display those.

When the implementation is finished, the README files should be updated with the new parameter.

Villanuevand commented 4 years ago

Hi @milantenk I would like to take this issue...

Could you assign it to me?

milantenk commented 4 years ago

Sure @Villanuevand, it is yours. :)

Villanuevand commented 4 years ago

@milantenk Thanks... Nice project BTW!

milantenk commented 4 years ago

Thank you! 😄

milantenk commented 4 years ago

I just merged the PR and created 1.1.0 version that contains the new feature. The package is deployed here to npm.js. Thank you for your contribution! 😄

Villanuevand commented 4 years ago

I just merged the PR and created 1.1.0 version that contains the new feature. The package is deployed here to npm.js. Thank you for your contribution! 😄

Im happy to help @milantenk If do you have a release plan for future features o enhancements o wherever to enhance the project, Feel free to ping me up!

I love this project...

milantenk commented 4 years ago

Okok, thank you! :)