search

milcent / benford_py

Python implementation of Benford's Law tests.
BSD 3-Clause "New" or "Revised" License
151 stars 52 forks source link

Update viz.py #39

Closed danilapilin closed 4 years ago

danilapilin commented 4 years ago

When calling the functions or methods that have show_plot as argument, there should also be an option to save the plot to a file. Milsent pls check it, I'm not sure, that I haven't forgotten anything

milcent commented 4 years ago

Sure. Just running short on time now, but I will definitely check it! I will probably have to make sure that is not any other plotting function/method in the Lib newer part (Benford class), so it can also benefit from this. Cheers

milcent commented 4 years ago

I have merged as it is, but I will continue to add saving figus functionality in a separate branch called feature/save_fig. Still some work to be done there. I intend to allow the possibility for the user to provide other args to plt.save_fig(), such as dpi... Continuing in Issue #38