search

milch / LRExportHEIC

MIT License
40 stars 4 forks source link

Add Option to Limit File Size? #2

Closed YoungCatChen closed 2 years ago

YoungCatChen commented 2 years ago

Hello Manu,

You may not know me, but I have been very grateful for this Lightroom Plugin that you built. I saved gigs of storages by re-export my library to HEIC, instead of JPG, while keeping the same quality. Thank you!

While I'm using this plugin, I found that I missed the "Limit File Size To" feature that Lightroom has built for JPG output. I wish your plugin could have it too!

You may or may not have the bandwidth for this feature... If you don't, I'm happy to help and to contribute to your plugin. A naive approach that I have to let the ExportHEICCommand.swift file call ctx.writeHEIF(10)Representation() multiple times, with different quality, to find the best approximation. If you are open to community contribution, do you feel good about it?

If you are happy about me contributing to your project, it will be great if you write down the instructions that someone can use to set up the environment. For example, clone your code, install certain SDK, compile, set this or that settings, check debug logs, etc. They will help a lot people like me who want to ramp up with this project.

Thank you in advance. Look forward to your reply!

YoungCat

milch commented 2 years ago

Hey, apologies for the delay in response, I wasn't getting email notifications for this repo from GitHub. I'll take a look at your PR

milch commented 2 years ago

I merged your CR, thanks again for your contribution. Happy that this is helping someone out there.