search

mildlygeeky / craft-timediff

Adds the Twig Date extension to Craft CMS
15 stars 3 forks source link

Craft 3 #2

Open himynameisphil opened 7 years ago

himynameisphil commented 7 years ago

Hey there, this is one of my favourite plugins to use with Craft! Just wondering, are there any plans to update it for use with Craft 3?

Thanks.

mildlygeeky commented 7 years ago

Thanks for the kind words! Yes, will certainly be updating it prior to Craft 3’s general release.

On Apr 22, 2017, at 10:24 AM, Phil Huggan notifications@github.com wrote:

Hey there, this is one of my favourite plugins to use with Craft! Just wondering, are there any plans to update it for use with Craft 3?

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mishellnovosel commented 6 years ago

Hi @mildlygeeky,

the Craft 3 is about to launch, is there any chance of having this awesome plugin updated for it now?

bstein-clever commented 5 years ago

Any updates here? I'm starting to look into the Craft 3 upgrade now that some other plugins I use are (almost) ready, but this one has no more info.

mishellnovosel commented 5 years ago

Any updates here? I'm starting to look into the Craft 3 upgrade now that some other plugins I use are (almost) ready, but this one has no more info.

I've ended up creating custom plugin based on logic from this one for Craft3 and importing it to Craft as Dev dependency ( otherwise it needs to be added as Plugin for Craft3 for which I didn't had time to do ).

bstein-clever commented 5 years ago

That would be awesome. It saves me having to do the same, and I'm sure others would find it useful., too. :) Thanks!

bstein-clever commented 5 years ago

Any updates here, @mishellnovosel?

mishellnovosel commented 5 years ago

Any updates here, @mishellnovosel?

Hi @bstein-clever, sorry, I was quite busy last few days. Please find the plugin here: https://github.com/mishellnovosel/craft3-timediff

Let me know if you have any issues ( you might want to check https://docs.craftcms.com/v3/extend/plugin-guide.html#loading-your-plugin-into-a-craft-project as well if you get stuck installing plugin on this way).

bstein-clever commented 5 years ago

Awesome! I've installed it successfully, but I'm in the middle of upgrading another custom plugin, so can't properly test it yet. I'll let you know if I run into anything else.

Thanks again.

bstein-clever commented 5 years ago

Testing this again now, I discovered that I couldn't actually use it in my page, the time_diff wasn't recognized. I realized I was missing a step of actually installing it in the control panel (under /admin/settings/plugins), but when I try that, I get an internal server error.

Checking the phperrors.log, I see: PHP Fatal error: Cannot declare class codecacao\time_diff\TimeDiffPlugin, because the name is already in use in /timediff/src/TimeDiffPlugin.php on line 0

Any thoughts?

mishellnovosel commented 5 years ago

Testing this again now, I discovered that I couldn't actually use it in my page, the time_diff wasn't recognized. I realized I was missing a step of actually installing it in the control panel (under /admin/settings/plugins), but when I try that, I get an internal server error.

Checking the phperrors.log, I see: PHP Fatal error: Cannot declare class codecacao\time_diff\TimeDiffPlugin, because the name is already in use in /timediff/src/TimeDiffPlugin.php on line 0

Any thoughts?

I've added the update to the plugin. Can you try it now? If it doesn't work, can you report issue on plugin page git? so we move away from this outdated plugin.

bstein-clever commented 5 years ago

Ha, that would have been the sensible thing, yes. It didn't help. Will move to https://github.com/mishellnovosel/craft3-timediff/issues/1