Replacing icon16 with dashicons

miled / wordpress-social-login

WordPress Social Login

http://miled.github.io/wordpress-social-login/

MIT License

398 stars 237 forks source link

Closed sabernhardt closed 2 years ago

sabernhardt commented 3 years ago

Looking at WordPress Trac #35717, the old icon16 classes may be deprecated soon.

The dashicons collection could replace those:

using toggle-indicator class for the gray color
adding alignleft to float the icon (with that, it can remain a div, but I had already changed it to a span)
including aria-hidden="true" so screen readers do not try reading the icon character

Screenshot before:

before

After changes, icons are slightly darker and align to the top of the cell:

after

sabernhardt commented 3 years ago

On second thought, it's probably better to define the color within the plugin instead of using the toggle-indicator class.