miledrousset / Opentheso

Nouvelle version du logiciel Opentheso avec un nouveau design
Other
26 stars 11 forks source link

Importing skos:editorialNote causes strange results #22

Closed adamretter closed 3 years ago

adamretter commented 3 years ago

Importing the following SKOS in RDF Turtle format:

@prefix dct:     <http://purl.org/dc/terms/> .
@prefix rdf:     <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix tna:     <http://www.nationalarchives.gov.uk/> .
@prefix xsd:     <http://www.w3.org/2001/XMLSchema#> .
@prefix skos:    <http://www.w3.org/2004/02/skos/core#> .
@prefix rdfs:    <http://www.w3.org/2000/01/rdf-schema#> .

<http://www.nationalarchives.gov.uk/ont.taxonomy.tna> rdf:type skos:ConceptScheme;
  dct:title "TNA Taxonomy" ;
  dct:language "en" ;
  dct:creator "Evolved Binary" ;
  dct:created "2021-02-18T17:10:00+01:00"^^xsd:dateTime .

<http://www.nationalarchives.gov.uk/topic.31>
      a       skos:Concept ;
      skos:inScheme <http://www.nationalarchives.gov.uk/ont.taxonomy.tna> ;
      skos:prefLabel "Forestry" .

<http://www.nationalarchives.gov.uk/topic.43>
      a       skos:Concept ;
      skos:inScheme <http://www.nationalarchives.gov.uk/ont.taxonomy.tna> ;
      skos:prefLabel "Merchant seaman" ;
      skos:related <http://www.nationalarchives.gov.uk/topic.55> ;
      skos:editorialNote "Example: I have decided to associate this with Public Disorder, as there are many records about Merchant seamen involved in acts of Public Disorder" .

<http://www.nationalarchives.gov.uk/topic.3R>
      a       skos:Concept ;
      skos:inScheme <http://www.nationalarchives.gov.uk/ont.taxonomy.tna> ;
      skos:prefLabel "Litigation" .

<http://www.nationalarchives.gov.uk/topic.55>
      a       skos:Concept ;    
      skos:inScheme <http://www.nationalarchives.gov.uk/ont.taxonomy.tna> ;
      skos:prefLabel "Public disorder" ;
      skos:broader <http://www.nationalarchives.gov.uk/topic.3R> .

Gives a strange view like the following, I had rather expected the preferred labels to appear in the Tree and not the Local Identifiers.

opentheso2-strange1

In addition, the tabs Index, Collection, and Tree remain empty too!

miledrousset commented 3 years ago

Your thesaurus was imported with the source language French, but the thesaurus is in English: change the thesaurus to the default source language (English), force the language of the notes with (@en) skos: editorialNote "Example: I have decided to associate this with Public Disorder, as there are many records about Merchant seamen involved in acts of Public Disorder @ en.

adamretter commented 3 years ago

Your thesaurus was imported with the source language French, but the thesaurus is in English: change the thesaurus to the default source language (English)

I could not find a mechanism to do that. It allowed me to create an additional language of English, but I couldn't seem to get it to change the default language.

We did set workLanguage=en during installation.

force the language of the notes with (@en)

Thanks. I will try converting our skos:prefLabel from xsd:string to rdf:langString and see if that helps...

miledrousset commented 3 years ago

I confirm, it's a bug, it's fixed. I will do an update next week. Thank you

miledrousset commented 3 years ago

I imported your example, it works Capture d’écran 2021-02-19 à 14 35 11 Capture d’écran 2021-02-19 à 14 35 26

adamretter commented 3 years ago

@miledrousset Okay great. I am guessing that you created the concept 'amphore' as it's not in our taxonomy?

miledrousset commented 3 years ago

yes indeed ;) I simply tested the automatic alignment to verify that the language is well processed