search

milen-ale / Space-Travelers-Hub

1 stars 1 forks source link

Space-Travelers-Hub #21

Open milen-ale opened 2 years ago

milen-ale commented 2 years ago

here is the link for the project : https://github.com/milen-ale/Space-Travelers-Hub/projects/1

Nemwel-Boniface commented 2 years ago

Hello @milen-ale and @markotuya0 :wave: ,

I am Nemwel your reviewer for this PR :man_beard:

Thank you for meeting all the project requirements good job! :partying_face: Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! :partying_face: 🎉

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️ Met all the milestone requirements ✔️

[Optional] suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.