Typecast issue when compiling on Particle

milesburton / Arduino-Temperature-Control-Library

Arduino Temperature Library

https://www.milesburton.com/w/index.php/Dallas_Temperature_Control_Library

969 stars 487 forks source link

Typecast issue when compiling on Particle #186

Closed karlg100 closed 3 years ago

karlg100 commented 3 years ago

Fails to compile on Paticle:

invalid conversion from 'const uint8_t* {aka const unsigned char*}' to 'uint8_t* {aka unsigned char*}' [-fpermissive]

Fix:

// returns true if address is valid
bool DallasTemperature::validAddress(const uint8_t* deviceAddress) {
    return (_wire->crc8((uint8_t*)deviceAddress, 7) == deviceAddress[DSROM_CRC]);
}

Fixed in #183

RobTillaart commented 3 years ago

LGTM

As it is part of #183 I propose to close this issue as it need no separate tracking.

karlg100 commented 3 years ago

I've tested this on my particles and works via the cloud IDE.