RobTillaart
commented
3 years ago Only had a quick glance at the code and do not pretend to understand all of it. Furthermore I do not have the hardware and time to reconstruct the problem.
That said, there is a loop where you request all temperatures and I recall that ESP's can give problems with WIFI (a.o) when code is blocking "too long". Solution is to put a call to yield() wherever blocking code is expected. yield() takes care that waiting processes in the background get the attention they need.
Around line 152 could be a candidate to insert a call to yield() Can you give it a try?
Possibly there are more similar loops to add yield() to,
T_MT_STATES isTemperatureMeasurementState(void)
{
bool completed = true;
float t;
if (LocalMeasureState == MEASURING)
{
// completed = ds.isConversionComplete();
if (TIMEOUT_EVENT(2))
{
for (int i = 0; i<dsDeviceCount; i++)
{
yield(): // <<<<<<<<<<<<<<<<<<<<<<
t = ds.getTempCByIndex(i); // bug ! it doesn't return the measure
//t = ds.getTempCByIndex(i); // if read 2 time then work, but if the program runs for hours the return value is frozen,
// to a specific value that doesn't change if the temperature change.
Temperatures[i] = t;
}
Serial.print("Local temperature value: ");
Serial.println(t);
Serial.print("Local temperature conversion stop time: ");
Serial.println(millis());
LocalMeasureState = COMPLETED;
} // if completed
} // if MeasuringTemperature
return(LocalMeasureState);
}
pberna67
sebitnt
Dear Developer
I found a major problem in your library as it is integrated with the UDP stack. In the example I am attaching, an ESP32 client (NINA W102) is connected to a local DS18B20 sensor, and through the wifi network to a UDP server (a ESP32 board with NINA W102) to which a DS18B20 sensors are connected. Every 10 seconds the local temperature sensor and a remote temperature sensor are read and stored in the Temperatures array []. The temperatures are printed on the serial.
The local temperature measurement is performed asynchronously by configuring the sensor with the function
ds.setWaitForConversion (0);the measurement of the local temperature is performed with the function
ds.getTempCByIndex ();after 2 seconds because using the function
ds.isConversionComplete ();it has been noticed that it returns immediately without waiting the 750ms (max) for the end of the conversion.
As you can see from the example, if remote sensors are excluded, the local sensor responds correctly and the local temperature is measured correctly, however if the temperature of the remote sensors is also read, the local sensor is no longer read correctly, the ds. getTempCByIndex () returns with a value of -127.
To reproduce the problem, launch the program TemperatureMonitor7MQTTClient_crash_1 (a reduced version of the full program) by assigning to the variable
EnableRemoteSensor = trueThe console reports the following result:
23:02:04.700 -> ⸮------- Multisensor temperature Acquisition System ---------- 23:02:04.700 -> Starting ITimer0 OK, millis() = 30 23:02:04.700 -> DayTimerSec: 0 23:02:04.700 -> 23:02:04.700 -> Number of local temperature devices found...: 1 23:02:04.700 -> DS12B80 address: 282F5D07D6013C62 23:02:04.734 -> Connecting to WiFi network: Vodafone-27586605 23:02:04.870 -> Waiting for WIFI connection... 23:02:05.074 -> WiFi connected On event IP address: 192.168.10.52 23:02:05.074 -> WiFi connected On event IP address: 192.168.10.52 23:02:14.694 -> Start measurements of the temperatures set... 23:02:14.694 -> Local temperature conversion start time: 10030 23:02:14.730 -> Send a request to read remote temperature sensor 23:02:14.730 -> READT command sent from: 192.168.10.52, port 1234 23:02:15.309 -> Received temperature packet of size: 6 From 192.168.10.43, port 1234, contents is: 19.37 23:02:16.706 -> Local temperature value: -127.00 23:02:16.706 -> Local temperature conversion stop time: 12032 23:02:16.706 -> Local software Timer time: 00:00:12 23:02:16.706 -> TEMP1: -127.00°C <------- Local Temperature (wrong result) 23:02:16.706 -> TEMP2: 19.37°C <------- Remote temperature OK 23:02:24.700 -> Start measurements of the temperatures set... 23:02:24.700 -> Local temperature conversion start time: 20030 23:02:24.700 -> Send a request to read remote temperature sensor 23:02:24.700 -> READT command sent from: 192.168.10.52, port 1234 23:02:25.214 -> Received temperature packet of size: 6 From 192.168.10.43, port 1234, contents is: 19.37 23:02:26.707 -> Local temperature value: -127.00 23:02:26.707 -> Local temperature conversion stop time: 22032 23:02:26.707 -> Local software Timer time: 00:00:22 23:02:26.707 -> TEMP1: -127.00°C 23:02:26.707 -> TEMP2: 19.37°C
if you assign the value false to
EnableRemoteSensor = falseyou will see:
23:07:06.571 -> ------- Multisensor temperature Acquisition System ---------- 23:07:06.571 -> Starting ITimer0 OK, millis() = 30 23:07:06.571 -> DayTimerSec: 0 23:07:06.571 -> 23:07:06.571 -> Number of local temperature devices found...: 1 23:07:06.571 -> DS12B80 address: 282F5D07D6013C62 23:07:06.605 -> Connecting to WiFi network: Vodafone-27586605 23:07:06.707 -> Waiting for WIFI connection... 23:07:06.944 -> WiFi connected On event IP address: 192.168.10.52 23:07:06.944 -> WiFi connected On event IP address: 192.168.10.52 23:07:16.554 -> Start measurements of the temperatures set... 23:07:16.554 -> Local temperature conversion start time: 10030 23:07:18.605 -> Local temperature value: 20.50 <------- Local Temperature (right result)
23:07:18.605 -> Local temperature conversion stop time: 12058 23:07:26.554 -> Start measurements of the temperatures set... 23:07:26.554 -> Local temperature conversion start time: 20030 23:07:28.590 -> Local temperature value: 26.37 <------- Local Temperature (right result)
23:07:28.590 -> Local temperature conversion stop time: 22058
If you don''t have a second board to install the remote server temperature, doesn't netter, you will see the similar result
More detail: ESP32 board package Version 1.0.5-rc4 DallasTemperature lib Version 3.9.0
TemperatureServer.zip TemperatureMonitor7MQTTClient_crash_1.zip