Fix build-CI + add badges to readme.md

milesburton / Arduino-Temperature-Control-Library

Arduino Temperature Library

https://www.milesburton.com/w/index.php/Dallas_Temperature_Control_Library

973 stars 487 forks source link

Fix build-CI + add badges to readme.md #217

Closed RobTillaart closed 2 years ago

RobTillaart commented 2 years ago

add badges to readme.md to easy see the results of build-CI (e.g. for updates / PR testing)
fix broken build CI,
- platforms tested (AVR, SAM, SAMD, ESP2866) these compile all examples.
- ESP32 gave problems (need to investigate)
LINT test OK
JSON test OK
unit tests can not be enabled
- build-CI environment cannot find "util/crc16.h" (need to investigate)

RobTillaart commented 2 years ago

@milesburton Why was this PR closed, it is the squashed version of the other PR.

milesburton commented 2 years ago

Cleaning house. Let me reopen

On Fri, 3 Jun 2022 at 09:40, Rob Tillaart @.***> wrote:

@milesburton https://github.com/milesburton Why was this PR closed, it is the squashed version of the other PR.

— Reply to this email directly, view it on GitHub https://github.com/milesburton/Arduino-Temperature-Control-Library/pull/217#issuecomment-1145735786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJGHM77PCDLA6BZNAE57JTVNHAHRANCNFSM5XXZFGFQ . You are receiving this because you were mentioned.Message ID: <milesburton/Arduino-Temperature-Control-Library/pull/217/c1145735786@ github.com>

milesburton commented 2 years ago

Apologies. Back to you @RobTillaart

RobTillaart commented 2 years ago

Understand, cleaning up is a good thing to do. Saw a lot of issues closed this morning and I thought it was a good moment to fix the build-CI script.

RobTillaart commented 2 years ago

Note about building ESP32 in build-CI - It fails on a low level gpio_mux call in OneWire. (not an issue for this library, but worth mentioning here)

RobTillaart commented 2 years ago

👍